Use cargo readme in ci #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt at checking if README is up to date in CI
usbalbin
force-pushed
the
use_cargo-readme_in_ci
branch
from
6e9adba
to
6f1001b
Compare
Merged
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
|
@usbalbin did you see my proposal to use : instead of ? It's avoid to write a temporary file, and in case of failure, it's permit to have all parts of the check in the In any case, thank's for the release 👍 |
|
Thank you :) Something like this #26 ? |
Yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing CI on top of #24
In lack of better words, this seems to fail successfully on the detected diff